Remove need to run invoke update after docker pull #6524
Conversation
only devel version
…pr/ChristianSchindler/6305
only in server process
matmair
added
docker
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
matmair
changed the title
|
For the db_version we shud properly replace it with InvenTree/InvenTree/version.py and ther shut also be a possibility to deactivate auto update with an environment variable |
|
This will have to be pushed to 0.15.0, the release window for 0.14.0 is to close |
|
@matmair can we use InvenTree/InvenTree/version.py for getting the version? |
…pr/ChristianSchindler/6305
…pr/ChristianSchindler/6305
|
This is working on my dev setup; would be happy for a review / general options @wolflu05 @SchrodingersGat |
There was a problem hiding this comment.
Only one question for me is open. What do you want to do with the options to invoke an update:
Options:
-f, --frontend Force frontend compilation/download step (ignores INVENTREE_DOCKER)
-k, --skip-static Skip static file collection step
-n, --no-frontend Skip frontend compilation/download step
-s, --skip-backup Skip database backup step (advanced users)
-u, --uv Use UV (experimental package manager)
The good thing would be adding another env, or so where you can add them to every invoke update in the script.
But in general, thanks for completing my idea really grade worker
There was a problem hiding this comment.
LGTM, this will simplify setups drastically, as there is no command that needs to be run manually.
Regarding @ChristianSchindler's comment, I do not really see the need for using the options from the update command in the docker container.
- the frontend commands should not be used as the frontend is already prebundeled in the container and any manual download or build will be ignored anyway
- skipping static collection doesn't make any sense either
- and using uv, think that doesn't work in the container either?
- and skipping backup, mh, maybe, but I dont think that hurts
Having an option to disable the automatic update process may be worth it, but not sure.
Personally I have to skip it because I use an unsupported version of postgres (postgres:16) and this is the only thing what is not working |
|
I do not plan to support unsupported configs |
Co-authored-by: ChristianSchindler <[email protected]>
That is way I only find it good to have the same possibly in the container as without it. I think you had also different reasons way you cracked this options for this script I do not think about |
|
@matmair in your opinion is this ready to merge?
|
|
This needs better testing and should be rewritten to use the app version as a reference for current thing. |
This PR adds a new script
contrib/container/execute.shthat checks if the API version of the starting image is different to the last checked version of the host and triggersinvoke updateautomatically.Fork details of 6305
Adoption of #6305, keeping the original commit by @ChristianSchindler to give co-authorship.
Removes the section we would not merge due to the comments brought up in #6305 (comment).
Keeps the great implementation of a database version check and auto-run of
inv update- making docker setup much easier.Ref #6303